-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send per queue metrics #3
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
let mut total_enqueued = 0; | ||
for (_queue_name, count) in enqueued_count_by_queue { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use something like https://doc.rust-lang.org/std/iter/trait.Sum.html
@@ -98,9 +98,8 @@ fn main() { | |||
|
|||
let mut previous_total_processed: Option<u32> = None; | |||
|
|||
debug!("Welcome to datadog-sidekiq"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given the usage of info!
around the existing code base I could see this as info!
as well (rather than debug!
).
thanks for your pull request and sorry for the long wait :) I left a few comments. on top of that, could you also update the 🥇 |
I have been tagged in a "too good to be real" crypto scam. I cannot flag it, could you @lipanski, please? Else, delete it if possible |
@PastorJordi I'm not sure what you mean. Flag/delete what exactly? |
Sorry about annoying you. |
👋 This sends metrics about each queue's enqueued count.
Added the print so that you know the container is doing something when it boots, and also moved the sleep to the end of the loop, so that it sends metrics before it 😴